Skip to content

Commit

Permalink
fix(pageserver): allow unused_imports in download.rs on macOS (#8733)
Browse files Browse the repository at this point in the history
## Problem

On macOS, clippy fails with the following error:

```
error: unused import: `crate::virtual_file::owned_buffers_io::io_buf_ext::IoBufExt`
  --> pageserver/src/tenant/remote_timeline_client/download.rs:26:5
   |
26 | use crate::virtual_file::owned_buffers_io::io_buf_ext::IoBufExt;
   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = note: `-D unused-imports` implied by `-D warnings`
   = help: to override `-D warnings` add `#[allow(unused_imports)]`
```

Introduced in #8717

## Summary of changes
- allow `unused_imports` for
`crate::virtual_file::owned_buffers_io::io_buf_ext::IoBufExt` on macOS
in download.rs
  • Loading branch information
bayandin authored Aug 15, 2024
1 parent fef77b0 commit a9c28be
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions pageserver/src/tenant/remote_timeline_client/download.rs
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ use crate::span::debug_assert_current_span_has_tenant_and_timeline_id;
use crate::tenant::remote_timeline_client::{remote_layer_path, remote_timelines_path};
use crate::tenant::storage_layer::LayerName;
use crate::tenant::Generation;
#[cfg_attr(target_os = "macos", allow(unused_imports))]
use crate::virtual_file::owned_buffers_io::io_buf_ext::IoBufExt;
use crate::virtual_file::{on_fatal_io_error, MaybeFatalIo, VirtualFile};
use crate::TEMP_FILE_SUFFIX;
Expand Down

1 comment on commit a9c28be

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2248 tests run: 2169 passed, 0 failed, 79 skipped (full report)


Code coverage* (full report)

  • functions: 32.4% (7217 of 22263 functions)
  • lines: 50.4% (58296 of 115720 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
a9c28be at 2024-08-15T11:01:29.622Z :recycle:

Please sign in to comment.