Skip to content

Commit

Permalink
tests: make size comparisons more lenient (#9388)
Browse files Browse the repository at this point in the history
The empirically determined threshold doesn't hold for PG 17.
Bump the limit to stabilise ci.
  • Loading branch information
VladLazar authored Oct 14, 2024
1 parent d92ff57 commit f4f7ea2
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions test_runner/regress/test_tenant_size.py
Original file line number Diff line number Diff line change
Expand Up @@ -479,9 +479,9 @@ def assert_size_approx_equal(size_a, size_b):
"""

# Determined empirically from examples of equality failures: they differ
# by page multiples of 8272, and usually by 1-3 pages. Tolerate 4 to avoid
# by page multiples of 8272, and usually by 1-3 pages. Tolerate 6 to avoid
# failing on outliers from that observed range.
threshold = 4 * 8272
threshold = 6 * 8272

assert size_a == pytest.approx(size_b, abs=threshold)

Expand Down

1 comment on commit f4f7ea2

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

5272 tests run: 5055 passed, 0 failed, 217 skipped (full report)


Flaky tests (2)

Postgres 17

Postgres 14

Code coverage* (full report)

  • functions: 31.4% (7547 of 24027 functions)
  • lines: 49.2% (60356 of 122720 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
f4f7ea2 at 2024-10-14T18:41:51.284Z :recycle:

Please sign in to comment.