safekeeper: eagerly return AppendResponse with flush_lsn
on segment fsync
#9688
Labels
a/performance
Area: relates to performance of the system
c/storage/safekeeper
Component: storage: safekeeper
When pipelining
AppendRequest
s, the WAL acceptor only returns anAppendResponse
with the newflush_lsn
when it itself explicitly requests a flush viaFlushWAL
:neon/safekeeper/src/receive_wal.rs
Lines 573 to 580 in 0d5a512
However, the WAL is also implicitly flushed on segment bounds:
neon/safekeeper/src/wal_storage.rs
Lines 308 to 310 in f18aa04
We should eagerly return an
AppendResponse
in this case, to allow the compute to commit up to that point.The text was updated successfully, but these errors were encountered: