Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pageserver): allow repartition errors during gc-compaction smoke tests #10164

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

skyzh
Copy link
Member

@skyzh skyzh commented Dec 16, 2024

Problem

part of #9114

In #10127 we fixed the race, but we didn't add the errors to the allowlist.

Summary of changes

  • Allow repartition errors in the gc-compaction smoke test.

I think it might be worth to refactor the code to allow multiple threads getting a copy of repartition status (i.e., using Rcu) in the future.

@skyzh skyzh requested review from problame and arpad-m December 16, 2024 20:06
@skyzh skyzh requested a review from a team as a code owner December 16, 2024 20:06
Copy link

7095 tests run: 6798 passed, 0 failed, 297 skipped (full report)


Flaky tests (3)

Postgres 17

Postgres 14

Code coverage* (full report)

  • functions: 31.4% (8397 of 26782 functions)
  • lines: 48.1% (66614 of 138627 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
b9eb484 at 2024-12-16T21:07:11.589Z :recycle:

@skyzh skyzh added this pull request to the merge queue Dec 18, 2024
Merged via the queue into main with commit 1d12efc Dec 18, 2024
84 checks passed
@skyzh skyzh deleted the skyzh/repartition-error-test branch December 18, 2024 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants