-
Notifications
You must be signed in to change notification settings - Fork 461
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set heartbeat interval for chaos test #10222
Open
knizhnik
wants to merge
10
commits into
main
Choose a base branch
from
set_heartbeat_interval_for_chaos_test
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7095 tests run: 6798 passed, 0 failed, 297 skipped (full report)Flaky tests (3)Postgres 17
Code coverage* (full report)
* collected from Rust tests only The comment gets automatically updated with the latest test results
58b6120 at 2024-12-24T08:58:20.949Z :recycle: |
ololobus
reviewed
Dec 23, 2024
@@ -60,7 +60,7 @@ impl Client { | |||
) -> anyhow::Result<PagestreamClient> { | |||
let copy_both: tokio_postgres::CopyBothDuplex<bytes::Bytes> = self | |||
.client | |||
.copy_both_simple(&format!("pagestream_v2 {tenant_id} {timeline_id}")) | |||
.copy_both_simple(&format!("pagestream_v3 {tenant_id} {timeline_id}")) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like you pushed a lot of unrelated changes related to the protocol change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, fixed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
See https://neondb.slack.com/archives/C033RQ5SPDH/p1734707873215729
test_timeline_archival_chaos becomes more fluky with increased heartbeat interval
Summary of changes
Override heatbeat interval for
test_timelirn_archival_chaos.py