Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: store and reuse docker builder cache for PRs #9102

Closed
wants to merge 1 commit into from

Conversation

bayandin
Copy link
Member

Problem

If PR contains significant changes for any docker image, all builds will take a significant amount of time, as there's no intermediate cache.

Summary of changes

  • Store docker builder cache for PRs and reuse it for consequent builds

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
  • If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

  • Do not forget to reformat commit message to not include the above checklist

Copy link
Contributor

@fedordikarev fedordikarev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link

4977 tests run: 4812 passed, 1 failed, 164 skipped (full report)


Failures on Postgres 17

# Run all failed tests locally:
scripts/pytest -vv -n $(nproc) -k "test_hot_standby_feedback[debug-pg17]"
Flaky tests (2)

Postgres 17

Test coverage report is not available

The comment gets automatically updated with the latest test results
d92e389 at 2024-09-23T17:16:17.375Z :recycle:

@bayandin
Copy link
Member Author

For some reason, docker rebuilds everything if it has unexisting image in --cache-from.. Going to close the PR for now, maybe we can think off more clever approach in the future

@bayandin bayandin closed this Sep 25, 2024
@bayandin bayandin deleted the bayandin/docker-cache-for-prs branch October 15, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants