Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

storcon: add tags to scheduler logs #9127

Merged
merged 1 commit into from
Sep 25, 2024
Merged

Conversation

VladLazar
Copy link
Contributor

We log something at info level each time we schedule a shard to a non-secondary location.
Might as well have context for it.

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
  • If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

  • Do not forget to reformat commit message to not include the above checklist

We log something at info level each time we schedule a shard to
a non-secondary location. Might as well have context for it.
@VladLazar VladLazar requested a review from a team as a code owner September 24, 2024 14:40
Copy link
Contributor

@yliang412 yliang412 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Is there any place that already logged these info not as a span? We might want to remove them.

@VladLazar
Copy link
Contributor Author

LGTM. Is there any place that already logged these info not as a span? We might want to remove them.

Did a quick spot check and doesn't seem to be the case.

Copy link

5012 tests run: 4848 passed, 0 failed, 164 skipped (full report)


Flaky tests (5)

Postgres 17

Postgres 15

  • test_ondemand_wal_download_in_replication_slot_funcs: release-x86-64

Postgres 14

Code coverage* (full report)

  • functions: 32.1% (7468 of 23243 functions)
  • lines: 50.0% (60190 of 120494 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
e4a3382 at 2024-09-24T17:59:58.188Z :recycle:

@VladLazar VladLazar merged commit a26cc29 into main Sep 25, 2024
81 of 82 checks passed
@VladLazar VladLazar deleted the vlad/improve-scheduling-logs branch September 25, 2024 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants