Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pageserver): passthrough partition cancel error #9154

Merged
merged 1 commit into from
Sep 25, 2024

Conversation

skyzh
Copy link
Member

@skyzh skyzh commented Sep 25, 2024

Problem

close #9142

Summary of changes

passthrough CollectKeyspaceError::Cancelled to CompactionError::ShuttingDown

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
  • If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

  • Do not forget to reformat commit message to not include the above checklist

@skyzh skyzh requested a review from arpad-m September 25, 2024 17:20
@skyzh skyzh requested a review from a team as a code owner September 25, 2024 17:20
Copy link

github-actions bot commented Sep 25, 2024

5039 tests run: 4875 passed, 0 failed, 164 skipped (full report)


Flaky tests (4)

Postgres 17

Postgres 16

Postgres 14

Code coverage* (full report)

  • functions: 32.0% (7495 of 23396 functions)
  • lines: 50.0% (60485 of 120856 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
b0f5962 at 2024-09-25T18:40:12.297Z :recycle:

@skyzh skyzh enabled auto-merge (squash) September 25, 2024 18:09
@skyzh skyzh merged commit 6a4f49b into main Sep 25, 2024
86 checks passed
@skyzh skyzh deleted the skyzh/passthrough-cancel-error branch September 25, 2024 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cancellation during compaction logged as error
2 participants