Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Silence clippy warning with nightly #9157

Merged
merged 1 commit into from
Sep 25, 2024
Merged

Conversation

hlinnaka
Copy link
Contributor

The warning:

warning: first doc comment paragraph is too long
  --> pageserver/src/tenant/checks.rs:7:1
   |
7  | / /// Checks whether a layer map is valid (i.e., is a valid result of the current compaction algorithm if no...
8  | | /// The function checks if we can split the LSN range of a delta layer only at the LSNs of the delta layer...
9  | | ///
10 | | /// ```plain
   | |_
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_long_first_doc_paragraph
   = note: `#[warn(clippy::too_long_first_doc_paragraph)]` on by default
help: add an empty line
   |
7  ~ /// Checks whether a layer map is valid (i.e., is a valid result of the current compaction algorithm if nothing goes wrong).
8  + ///
   |

Fix by applying the suggestion.

The warning:

    warning: first doc comment paragraph is too long
      --> pageserver/src/tenant/checks.rs:7:1
       |
    7  | / /// Checks whether a layer map is valid (i.e., is a valid result of the current compaction algorithm if no...
    8  | | /// The function checks if we can split the LSN range of a delta layer only at the LSNs of the delta layer...
    9  | | ///
    10 | | /// ```plain
       | |_
       |
       = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_long_first_doc_paragraph
       = note: `#[warn(clippy::too_long_first_doc_paragraph)]` on by default
    help: add an empty line
       |
    7  ~ /// Checks whether a layer map is valid (i.e., is a valid result of the current compaction algorithm if nothing goes wrong).
    8  + ///
       |

Fix by applying the suggestion.
@hlinnaka hlinnaka requested a review from a team as a code owner September 25, 2024 20:24
@hlinnaka hlinnaka enabled auto-merge (squash) September 25, 2024 20:29
Copy link

github-actions bot commented Sep 25, 2024

5065 tests run: 4901 passed, 0 failed, 164 skipped (full report)


Flaky tests (10)

Postgres 17

Postgres 16

Postgres 15

Postgres 14

Code coverage* (full report)

  • functions: 32.0% (7491 of 23395 functions)
  • lines: 50.0% (60475 of 120849 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
b37d204 at 2024-09-25T21:40:31.892Z :recycle:

@tristan957
Copy link
Member

kicked your CI

@hlinnaka hlinnaka merged commit 7e560dd into main Sep 25, 2024
81 checks passed
@hlinnaka hlinnaka deleted the silence-nightly-clippy branch September 25, 2024 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants