Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: Increase timeout in test_create_churn_during_restart #9736

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

hlinnaka
Copy link
Contributor

@hlinnaka hlinnaka commented Nov 12, 2024

This test was seen to be flaky, e.g. at
https://neon-github-public-dev.s3.amazonaws.com/reports/pr-9457/11804246485/index.html#suites/ec4311502db344eee91f1354e9dc839b/982bd121ea698414/.
If I reduce the timeout from 10s to 8s on my laptop, it reliably hits that timeout and fails. That suggests that the test is pretty close to the edge even when it passes. Let's bump up the timeout to 30 s to make it more robust.

See also #9730, although the error message is different there.

@hlinnaka hlinnaka marked this pull request as ready for review November 12, 2024 23:21
This test was seen to be flaky, e.g. at
https://neon-github-public-dev.s3.amazonaws.com/reports/pr-9457/11804246485/index.html#suites/ec4311502db344eee91f1354e9dc839b/982bd121ea698414/.
If I _reduce_ the timeout from 10s to 8s on my laptop, it reliably
hits that timeout and fails. That suggests that the test is pretty
close to the edge even when it passes. Let's bump up the timeout to 30
s to make it more robust.

See also #9730, although
the error message is different there.
@hlinnaka hlinnaka force-pushed the unflake-test_create_churn_during_restart branch from 5a21c20 to 2e14322 Compare November 12, 2024 23:22
@hlinnaka hlinnaka mentioned this pull request Nov 12, 2024
5 tasks
Copy link

5382 tests run: 5162 passed, 0 failed, 220 skipped (full report)


Flaky tests (3)

Postgres 17

Code coverage* (full report)

  • functions: 31.8% (7891 of 24834 functions)
  • lines: 49.5% (62454 of 126257 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
2e14322 at 2024-11-13T00:27:49.319Z :recycle:

@jcsp
Copy link
Collaborator

jcsp commented Nov 13, 2024

In the log linked, a timeline creation takes 5 seconds. I can see how that happens in CI when nodes are very overloaded, I'm a bit surprised it was readily reproducible on a (presumably fast) local laptop.

@hlinnaka
Copy link
Contributor Author

In the log linked, a timeline creation takes 5 seconds. I can see how that happens in CI when nodes are very overloaded, I'm a bit surprised it was readily reproducible on a (presumably fast) local laptop.

Not a very fast laptop, and I compile in debug mode, and using cranelift which probably creates even slower binaries :-).

@jcsp
Copy link
Collaborator

jcsp commented Nov 13, 2024

think there may be a real bug here, but don't mind bumping the timeout in the interim:
#9730 (comment)

@hlinnaka hlinnaka merged commit d5435b1 into main Nov 13, 2024
80 checks passed
@hlinnaka hlinnaka deleted the unflake-test_create_churn_during_restart branch November 13, 2024 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants