-
Notifications
You must be signed in to change notification settings - Fork 442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
proxy: Implement cancellation rate limiting #9739
Open
awarus
wants to merge
1
commit into
main
Choose a base branch
from
cancel-rate-limit
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awarus
force-pushed
the
cancel-rate-limit
branch
from
November 13, 2024 09:31
faa78af
to
344f506
Compare
5490 tests run: 5247 passed, 0 failed, 243 skipped (full report)Code coverage* (full report)
* collected from Rust tests only The comment gets automatically updated with the latest test results
2e7de01 at 2024-11-15T17:35:48.624Z :recycle: |
cloneable
reviewed
Nov 13, 2024
awarus
force-pushed
the
cancel-rate-limit
branch
from
November 14, 2024 16:30
344f506
to
c07e4ae
Compare
awarus
force-pushed
the
cancel-rate-limit
branch
from
November 15, 2024 08:48
c07e4ae
to
5579b38
Compare
cloneable
reviewed
Nov 15, 2024
awarus
force-pushed
the
cancel-rate-limit
branch
from
November 15, 2024 15:56
5579b38
to
9659a6e
Compare
awarus
force-pushed
the
cancel-rate-limit
branch
from
November 15, 2024 16:19
9659a6e
to
457f0ca
Compare
Implement cancellation rate limiting using GlobalRateLimiter and perform ip allowlist checks. Add ip_allowlist to the cancel closure. Fixes #16456
awarus
force-pushed
the
cancel-rate-limit
branch
from
November 15, 2024 16:37
457f0ca
to
2e7de01
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement cancellation rate limiting and ip allowlist checks. Add ip_allowlist to the cancel closure
Fixes #16456