Add GUC controlling whether to pause recovery if some critical GUCs at replica have smaller value than on primary #501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
MMeent
requested changes
Sep 19, 2024
knizhnik
force-pushed
the
pause_recovery_at_misconfig_v16
branch
from
0bb232c to
b47180d
Compare
hlinnaka
reviewed
Oct 30, 2024
knizhnik
force-pushed
the
pause_recovery_at_misconfig_v16
branch
from
b47180d to
e6e8408
Compare
hlinnaka
reviewed
Nov 27, 2024
| if (!recoveryPauseOnMisconfig) | ||
| if (!allowReplicaMisconfig) | ||
| { | ||
| /* Сontinue replication even though it can cause problerms later */ |
There was a problem hiding this comment.
Suggested change
| /* Сontinue replication even though it can cause problerms later */ | |
| /* Сontinue replication even though it can cause problems later */ |
MMeent
reviewed
Nov 27, 2024
MMeent
approved these changes
Nov 28, 2024
knizhnik
force-pushed
the
pause_recovery_at_misconfig_v16
branch
from
69e778a to
732f740
Compare
added 4 commits
November 29, 2024 16:51
…t replica have smaller value than on primary
knizhnik
force-pushed
the
pause_recovery_at_misconfig_v16
branch
from
732f740 to
d05e846
Compare
github-merge-queue bot
pushed a commit
to neondatabase/neon
that referenced
this pull request
Dec 1, 2024
…t replica have smaller value than on primary (#9057) ## Problem See #9023 ## Summary of changes Ass GUC `recovery_pause_on_misconfig` allowing not to pause in case of replica and primary configuration mismatch See neondatabase/postgres#501 See neondatabase/postgres#502 See neondatabase/postgres#503 See neondatabase/postgres#504 ## Checklist before requesting a review - [ ] I have performed a self-review of my code. - [ ] If it is a core feature, I have added thorough tests. - [ ] Do we need to implement analytics? if so did you add the relevant metrics to the dashboard? - [ ] If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section. ## Checklist before merging - [ ] Do not forget to reformat commit message to not include the above checklist --------- Co-authored-by: Konstantin Knizhnik <[email protected]> Co-authored-by: Heikki Linnakangas <[email protected]>
awarus
pushed a commit
to neondatabase/neon
that referenced
this pull request
Dec 5, 2024
…t replica have smaller value than on primary (#9057) ## Problem See #9023 ## Summary of changes Ass GUC `recovery_pause_on_misconfig` allowing not to pause in case of replica and primary configuration mismatch See neondatabase/postgres#501 See neondatabase/postgres#502 See neondatabase/postgres#503 See neondatabase/postgres#504 ## Checklist before requesting a review - [ ] I have performed a self-review of my code. - [ ] If it is a core feature, I have added thorough tests. - [ ] Do we need to implement analytics? if so did you add the relevant metrics to the dashboard? - [ ] If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section. ## Checklist before merging - [ ] Do not forget to reformat commit message to not include the above checklist --------- Co-authored-by: Konstantin Knizhnik <[email protected]> Co-authored-by: Heikki Linnakangas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See neondatabase/neon#9023