Skip to content

Add GUC controlling whether to pause recovery if some critical GUCs at replica have smaller value than on primary #503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 30, 2024
Merged

Add GUC controlling whether to pause recovery if some critical GUCs at replica have smaller value than on primary #503

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
73f1b50
Add GUC controlling whether to pause recovery if some critical GUCs a…
Sep 19, 2024
ae2f012
Do not throw fatal error when confiuration of primary and replica do …
Sep 23, 2024
9ce3a11
Rename GUC to allow_replica_misconfig
Nov 27, 2024
82f5da0
Fix condition for pausing replciation
Nov 28, 2024
972e325
Allow replica startup on misconfig by default
Nov 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 18 additions & 1 deletion src/backend/access/transam/xlogrecovery.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,7 @@ TimestampTz recoveryTargetTime;
const char *recoveryTargetName;
XLogRecPtr recoveryTargetLSN;
int recovery_min_apply_delay = 0;
bool allowReplicaMisconfig = true; /* NEON: GUC is defined in neon extension */

/* options formerly taken from recovery.conf for XLOG streaming */
char *PrimaryConnInfo = NULL;
Expand Down Expand Up @@ -4858,6 +4859,12 @@ RecoveryRequiresIntParameter(const char *param_name, int currValue, int minValue
currValue,
minValue)));

if (allowReplicaMisconfig)
{
/* Сontinue replication even though it can cause problems later */
return;
}

SetRecoveryPause(true);

ereport(LOG,
Expand Down Expand Up @@ -4906,7 +4913,17 @@ RecoveryRequiresIntParameter(const char *param_name, int currValue, int minValue
ConditionVariableCancelSleep();
}

ereport(FATAL,
if (allowReplicaMisconfig)
ereport(WARNING,
(errcode(ERRCODE_INVALID_PARAMETER_VALUE),
errmsg("Insufficient parameter settings can cause problems during recovery"),
/* Repeat the detail from above so it's easy to find in the log. */
errdetail("%s = %d is a lower setting than on the primary server, where its value was %d.",
param_name,
currValue,
minValue)));
else
ereport(FATAL,
(errcode(ERRCODE_INVALID_PARAMETER_VALUE),
errmsg("recovery aborted because of insufficient parameter settings"),
/* Repeat the detail from above so it's easy to find in the log. */
Expand Down
1 change: 1 addition & 0 deletions src/include/access/xlogrecovery.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,7 @@ extern PGDLLIMPORT char *PrimarySlotName;
extern PGDLLIMPORT char *recoveryRestoreCommand;
extern PGDLLIMPORT char *recoveryEndCommand;
extern PGDLLIMPORT char *archiveCleanupCommand;
extern PGDLLIMPORT bool allowReplicaMisconfig;

/* indirectly set via GUC system */
extern PGDLLIMPORT TransactionId recoveryTargetXid;
Expand Down