make raw_txt not prepare statements #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
conradludgate
commented
Oct 31, 2023
•
conradludgate
commented
- no longer call get_type during query_txt
- expose get_type publically so we can still get type info later
5 tasks
conradludgate
commented
Oct 31, 2023
| let mut parameters = vec![]; | ||
| let mut it = parameter_description.parameters(); | ||
| while let Some(oid) = it.next().map_err(Error::parse)? { | ||
| let type_ = Type::from_oid(oid).unwrap_or(Type::UNKNOWN); |
There was a problem hiding this comment.
this is the major difference over the previous impl. it no longer does a get_type call.
petuhovskiy
approved these changes
Nov 2, 2023
conradludgate
added a commit
to neondatabase/neon
that referenced
this pull request
Nov 3, 2023
## Problem my prepared statements change in tokio-postgres landed in the latest release. it didn't work as we intended ## Summary of changes neondatabase/rust-postgres#24
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.