Revert "allow arbitrary config params with more efficient repr (#30)" #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit cff6927.
hlinnaka
approved these changes
Nov 14, 2024
VladLazar
added a commit
to neondatabase/neon
that referenced
this pull request
Nov 14, 2024
## Problem We are pining our fork of rust-postgres to a commit hash and that prevents us from making further changes to it. The latest commit in rust-postgres requires #8747, but that seems to have gone stale. I reverted rust-postgres `neon` branch to the pinned commit in neondatabase/rust-postgres#31. ## Summary of changes Switch back to using the `neon` branch of the rust-postgres fork.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit cff6927.
We currently pin to HEAD^ of the neon branch in the
neonrepo (here). Before using the commit being reverted, neondatabase/neon#8747 needs to merge, but that seems to have gone stale.So let's revert to unblock making new changes and revisit the issue separately.