Small fixes and dependency updates #159
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ape fns), plus updated publish instructions
lneves12
reviewed
Apr 26, 2025
| @@ -61,7 +61,7 @@ | |||
| "test:browser": "npm run build && playwright install --with-deps firefox chromium && vitest run --dir=tests/browser --browser --config=tests/browser/vite.config.mts" | |||
| }, | |||
| "dependencies": { | |||
| "@types/node": "^22.10.2", | |||
| "@types/node": "*", | |||
There was a problem hiding this comment.
what was the main reason to wildcard this dependency? Always looks scary to wildcard dependencies like that, even if types
|
Should we also set up some changelogs? |
pffigueiredo
approved these changes
Apr 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-export
escapeIdentifierfrom pg #154 — asks to exportescapeLiteralandescapeIdentifier: this does so.Module not found "https://jsr.io/@neon/serverless/0.10.1/pg-protocol" #112 — points out an issue with Deno/JSR, which is that we pin to a version of
@types/pgthat does not exist. Oops! This fixes that too.The
postversionscript now points out the need to publish to JSR.All packages (except
pg, which is pinned to 8.8.0) are updated, fixing some security warnings. Prisma (or at least its type definition) appears to have changed in 6.6.0, so the relevant tests are updated and simplified to match. Since we now rely on Prisma to import@neondatabase/serverlessfor itself, I have added anoverridefield inpackage.jsonto ensure it uses the local package, not whatever version is currently on npm.