-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NDEV-2475 collect metrics for requests to Solana #51
Conversation
e4af442
to
028818b
Compare
3c22dc1
to
de900ed
Compare
|
35a65df
to
aa52e92
Compare
|
5dc323b
to
a1b069d
Compare
5335683
to
5456cc6
Compare
.github/workflows/pipeline.yml
Outdated
if: | | ||
always() && | ||
contains(fromJSON('["success", "cancelled", "failure", "skipped", "completed"]'), needs.openzeppelin-tests.result) && | ||
contains(fromJSON('["success", "cancelled", "failure", "skipped", "completed"]'), needs.basic-tests.result) && |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
basic tests can't be skipped
I think always() is aanough here if you all statuses are good for the job
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense. I have removed check for the basic tests 👍
Solana Requests Statistics
|
No description provided.