Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added tests to check account list #509

Open
wants to merge 12 commits into
base: develop
Choose a base branch
from

Conversation

kristinaNikolaevaa
Copy link
Collaborator

No description provided.

Copy link
Collaborator

@sshiganov sshiganov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I have a couple of suggestions to improve maintainability and readability:

  1. Encapsulate Solana Transaction Handling in web3_client

    • Move the logic for fetching and extracting sol_trx into a new method in web3_client, e.g., get_solana_accounts_by_neon(transaction_hash).
    • This will abstract away internal details and make the test cleaner.
  2. Extract Assertions into a Separate Method

    • The check for precompile_program_address in sol_accounts should be a dedicated method, improving reusability and readability.
    • This method can receive both a single address to check or a list, if required
  3. Improve Logging and Debugging

    • Consider adding debug logs before assertions to aid troubleshooting.
    • Update assertion failure messages to provide more context.

@kristinaNikolaevaa
Copy link
Collaborator Author

@sshiganov done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants