BUGFIX: Drop use of E_STRICT to fix PHP 8.4 deprecation
#3437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The use of `E_STRICT` is deprecated as of PHP 8.4, so this fixes deprecation warnings. Furthermore, the constant is no longer useful… In PHP 5.4, the functionality of `E_STRICT` was incorporated into `E_ALL`, meaning strict standards notices are included in the `E_ALL` error level. As a result, there is no need to use `E_STRICT` separately starting with PHP 5.4. This change is documented in the PHP manual under the migration guide for PHP 7.0, which states: > All of the E_STRICT notices have been reclassified to other levels. > The E_STRICT constant is retained, so calls like > `error_reporting(E_ALL|E_STRICT)` will not cause an error. (see https://www.php.net/manual/en/migration70.incompatible)
dlubitz
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The use of
E_STRICTis deprecated as of PHP 8.4, so this fixes deprecation warnings. Furthermore, the constant is no longer useful…In PHP 5.4, the functionality of
E_STRICTwas incorporated intoE_ALL, meaning strict standards notices are included in theE_ALLerror level. As a result, there is no need to useE_STRICTseparately starting with PHP 5.4. This change is documented in the PHP manual under the migration guide for PHP 7.0, which states:(see https://www.php.net/manual/en/migration70.incompatible)
Checklist
FEATURE|TASK|BUGFIXReviewer - Breaking Changes are marked with!!!and have upgrade-instructions