Delete uploaded resource after failed validation

[fdchriswaechter]

Problem: When a file is uploaded using the FormUpload element, it is immediately saved to the resource collection upon form submission. However, if the file is later deemed invalid, it still occupies server storage, leading to unnecessary and potentially significant consumption of storage space.

Implementation: The \Neos\Form\Validation\FileTypeValidator now utilizes an injected resource manager. If a file fails validation, the resource manager deletes the corresponding file and entry in the DB, preventing invalid files from being permanently stored and conserving server storage space.

[kitsunet]

Thank you for this fix! I understand the problem and there might not be a good place to fix this, my only worry would be that this deletes the file in some cases but not in others (for example if the validation fails on something else and no resubmit happens).

I'll have a closer look.

[bwaidelich]

Thanks for the contribution and sorry for the -1 but I don't think that a validator should have side effects – especially not such dramatic ones.
We could make it configurable I suppose, but I would suggest to go a different route.
For example we could hook into the form submission to remove invalid files. But we would always have the hen-egg situation that @kitsunet described.
So instead we should promote (and document) how to use protected (and temporary?) resourceCollections and a finisher that publishes the file to some public collection (if that's needed at all, for storing/sending the file it is not) like suggested with neos/form-builder#137