Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

!!! FEATURE: Overhaul node uri building #4892

Merged
merged 21 commits into from
Jun 23, 2024

Commits on May 22, 2024

  1. Configuration menu
    Copy the full SHA
    ba13da3 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    cf8c35b View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    c824604 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    9cfc16f View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    c1a33c1 View commit details
    Browse the repository at this point in the history
  6. TASK: Introduce NodeUri Options in favour of NodeUriSpecification

    The api will be
    
    ```
    public function uriFor(NodeAddress $nodeAddress, Options $options = null): UriInterface
    ```
    mhsdesign committed May 22, 2024
    Configuration menu
    Copy the full SHA
    754f735 View commit details
    Browse the repository at this point in the history

Commits on May 23, 2024

  1. Configuration menu
    Copy the full SHA
    3ebf6bb View commit details
    Browse the repository at this point in the history

Commits on May 25, 2024

  1. TASK: Fix preview uri building to ignore custom options

    the custom options will likely be unintended as `uriFor` uses preview uris for non-live uris.
    Such preview route will likely not exist, and thus it will just provoke hard to debug errors.
    mhsdesign committed May 25, 2024
    Configuration menu
    Copy the full SHA
    f175873 View commit details
    Browse the repository at this point in the history
  2. TASK: Document NodeUriBuilder and align behaviour to flows UriBuilder

    - Use flows base uri if configured for sub dir installations
    - Pass `uriPathPrefix` correctly along when base uri is configured
    - support for `FLOW_REWRITEURLS === ß` is not planned as this option is to be removed
    mhsdesign committed May 25, 2024
    Configuration menu
    Copy the full SHA
    e855be8 View commit details
    Browse the repository at this point in the history

Commits on May 28, 2024

  1. Configuration menu
    Copy the full SHA
    47a4a13 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    2c4670c View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    ceb88ab View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    2afdf6b View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    8887e77 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    c34eb9b View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    95f1c5e View commit details
    Browse the repository at this point in the history

Commits on Jun 5, 2024

  1. Configuration menu
    Copy the full SHA
    b08d248 View commit details
    Browse the repository at this point in the history

Commits on Jun 14, 2024

  1. Configuration menu
    Copy the full SHA
    18f8724 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    f0ba008 View commit details
    Browse the repository at this point in the history

Commits on Jun 16, 2024

  1. TASK: Restore feature to keep current format of action request when b…

    …uilding uris from Fusion or Fluid
    
    The magic of keeping the format either has helped (by knowing it beforehand) or worse lead to confusion and hard to debug uri building errors (the `@format: json` part in the exception dump tends to go unnoticed for the untrained eye)
    
    Still for this change it would be cruel to change behaviour like this so we reimplement it.
    mhsdesign committed Jun 16, 2024
    Configuration menu
    Copy the full SHA
    95fa4cb View commit details
    Browse the repository at this point in the history
  2. TASK: Introduce dedicated Options::withForceAbsolute

    The filter like signatures dont feel quite right because they only have one argument ... and its a yagni to add new args
    mhsdesign committed Jun 16, 2024
    Configuration menu
    Copy the full SHA
    a69fed4 View commit details
    Browse the repository at this point in the history