Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TASK: list packages by loading order in BE Module #5142

Open
wants to merge 1 commit into
base: 8.4
Choose a base branch
from

Conversation

crydotsnake
Copy link
Member

@crydotsnake crydotsnake commented Jun 16, 2024

Upgrade instructions

None

Review instructions

This pull request is related too: neos/flow-development-collection#3363

There we decided to list the packages by their loading order in the flow:package:list command.

This pull request takes care that the packages are listed by the loading order in the backend module too.

Checklist

  • Code follows the PSR-2 coding style
  • Tests have been created, run and adjusted as needed
  • The PR is created against the lowest maintained branch
  • Reviewer - PR Title is brief but complete and starts with FEATURE|TASK|BUGFIX
  • Reviewer - The first section explains the change briefly for change-logs
  • Reviewer - Breaking Changes are marked with !!! and have upgrade-instructions

@Sebobo
Copy link
Member

Sebobo commented Jun 16, 2024

The module should then show an information about the order.

Btw. I usually prefer alphabetical order as customers tend to show me that list when we discuss updates.
Via screenshare the alphabetical order is more useful for me than the loading order.

Probably better to ask the community what they think or if people actually don't care.

Or make it switchable.

@crydotsnake
Copy link
Member Author

Personally i would be fine to sort the package by alphabetical order

Wdyt? @mhsdesign @kitsunet @ahaeslich

@ahaeslich
Copy link
Member

If we have use cases where either the alphabetical or loading order is needed, I would go with the option "make it sortable". As in "let the user decide which order is needed now".

If we decide to have this selection in the backend module: how can we be sure the alphabetical order isn't needed by someone in the CLI (see: neos/flow-development-collection#3363)? Is there any need to remove it there?

@crydotsnake
Copy link
Member Author

How do we continue here? Should we sort it by alphabetical order by default? or give the editor the option to also sort it by loading order?

@crydotsnake
Copy link
Member Author

@Sebobo Maybe i could solve it the same way as you did it in: #5209

So that there would be a dropdown selector with the two options for example:

  • Sort by Alphabetical order
  • Sort by loading order.

Wdyt?

@Sebobo
Copy link
Member

Sebobo commented Sep 9, 2024

Allow clicking on the headers to sort the table with alphabetical being the default plz :)

@crydotsnake
Copy link
Member Author

Allow clicking on the headers to sort the table with alphabetical being the default plz :)

So now dropdown selector? and only by alphabetical order or with a another click by loading order too?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants