-
-
Notifications
You must be signed in to change notification settings - Fork 221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FEATURE: Improve user sorting behavior #5159
base: 8.4
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, why not... But is this really all that is needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wait a sec, this doesnt look particular light anymore ;) it seems it was not minified?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Huh, interesting
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I compiled everything again after the rebase 🤔.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Realized just now, did you maybe not do yarn build:production
? That seems to work fine for me.
Mh. I thought i exactly did that. I recompiled the files with |
Why are the PHP Tests failing? |
4a46ffe
to
6f80e14
Compare
I think the php errors are not your fault, but tahter a problem of 8.4 and behat... |
…ehavior FEATURE: Improve User sorting behavior in user management backend module
6f80e14
to
1616e8d
Compare
Ready for review! But PHP tests are still failing after a rebase.. |
Upgrade instructions
None
Review instructions
I added this feature for 9.0 but since we want to release a Neos 8.4 i cherry-picked the commit so we have this small feature already in Neos 8.4!
For more details have a look at the original PR: #4443
Checklist
FEATURE|TASK|BUGFIX
!!!
and have upgrade-instructions