BUGFIX: Share same role details when adding user as when editing them #5206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When editing users, much more information was shown about the individual roles than when adding a user, where whoever adds them gets no information about the role except its name. With this change the descriptions of the role and their individual privileges are displayed in the same way as in the edit account view.
Sebobo
force-pushed
the
bugfix/role-descriptions-on-create
branch
from
5d78038
to
3418511
Compare
|
Sooo this could also go into 8.4 if considered a feature due to the extraction of some code into a partial. |
crydotsnake
approved these changes
Sep 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When editing users, much more information was shown about the individual roles than when adding a user, where whoever adds them gets no information about the role except its name.
With this change the descriptions of the role and their individual privileges are displayed in the same way as in the edit account view.
Review instructions
Before:
After:
Current edit account view: