Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUGFIX: Remove rootnode when user workspace is deleted #5207

Merged
merged 1 commit into from
Sep 9, 2024
Merged

BUGFIX: Remove rootnode when user workspace is deleted #5207

merged 1 commit into from
Sep 9, 2024

Conversation

Sebobo
Copy link
Member

@Sebobo Sebobo commented Aug 16, 2024

Fixes: #2193

Review instructions

Previously all root nodes of workspaces that belonged to removed users stayed in the database.
With this change, the root nodes are removed as well.

  1. Create a user
  2. Delete the new user
  3. No root node should remain of the personal workspace of the removed user

@Sebobo Sebobo added Bug 8.3 P: User Management Anything related to the user module labels Aug 16, 2024
@Sebobo
Copy link
Member Author

Sebobo commented Aug 16, 2024

I tried before to fix this via a doctrine annotation but failed. This worked though.

@Sebobo
Copy link
Member Author

Sebobo commented Aug 16, 2024

Should I add a migration that gets rid of the lost rootnodes?

kitsunet
kitsunet approved these changes Sep 4, 2024
View reviewed changes
Copy link
Member

@kitsunet kitsunet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like thank you! I don't think a migration is super important but 🤷

@Sebobo Sebobo merged commit e491b59 into 8.3 Sep 9, 2024
9 checks passed
@Sebobo Sebobo deleted the bugfix/remove-rootnode-when-deleting-users branch September 9, 2024 07:15
@Sebobo
Copy link
Member Author

Sebobo commented Sep 9, 2024

I skip the migration for now as node:repair cleanes the nodes up too afaik

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kitsunet kitsunet kitsunet approved these changes

@crydotsnake crydotsnake crydotsnake approved these changes

@bwaidelich bwaidelich Awaiting requested review from bwaidelich

@dlubitz dlubitz Awaiting requested review from dlubitz

Assignees
No one assigned
Labels
8.3 Bug P: User Management Anything related to the user module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Sebobo @kitsunet @crydotsnake