Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUGFIX: cr:projectionReplay cli progress advancing #5214

Conversation

mhsdesign
Copy link
Member

Upgrade instructions

Review instructions

Why dont we have a linter for that :O

Checklist

  • Code follows the PSR-2 coding style
  • Tests have been created, run and adjusted as needed
  • The PR is created against the lowest maintained branch
  • Reviewer - PR Title is brief but complete and starts with FEATURE|TASK|BUGFIX
  • Reviewer - The first section explains the change briefly for change-logs
  • Reviewer - Breaking Changes are marked with !!! and have upgrade-instructions

@mhsdesign
Copy link
Member Author

Only if when adding @phpstan-pure to \Neos\ContentRepository\Core\Projection\CatchUpOptions::with the linter would have caught that:

  Line   Neos.ContentRepositoryRegistry/Classes/Command/CrCommandController.php                                                                                    
 ------ ---------------------------------------------------------------------------------------------------------------------------------------------------------- 
  131    Call to method Neos\ContentRepository\Core\Projection\CatchUpOptions::with() on a separate line has no effect.  

We need to tell phpstan somehow that things are pure ...

@nezaniel nezaniel self-requested a review August 26, 2024 07:28
Copy link
Member

@nezaniel nezaniel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mhsdesign mhsdesign merged commit d7ed797 into neos:9.0 Aug 27, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants