TASK: Use proper version checks where applicable

[bwaidelich]

Replaces some ExpectedVersion::ANY() occurrences with proper versions the decisions were based on.

Note: With this change there are 8 ExpectedVersion::ANY() left in the WorkspaceCommandHandler that would require the workspace read model to keep track of the version. There are three more occurrences in CommandSimulator and ContentStreamHandling that are kept by intention

Related: #5058

[mhsdesign]

For the following cases in the WorkspaceCommandHandler ExpectedVersion::ANY() is used while we could change that at least to ExpectedVersion::STREAM_EXISTS()? For most cases - because we issue multiple events - we dont want this check to ever fail, and it wont because the stream will continue to exist, even if someone deletes the workspace at the same time - that we have to prevent actually :D.

• handlePublishWorkspace
• handleRebaseWorkspace
• handlePublishIndividualNodesFromWorkspace
• handleDiscardIndividualNodesFromWorkspace
• discardWorkspace
• handleChangeBaseWorkspace
• handleDeleteWorkspace

Further i found a few missing ExpectedVersion::ANY() checks in the structure adjustments - but i think we dont have access to the content stream version here ...

[mhsdesign]

this slight change has a big impact as now after deleting a workspace a new one with the exact same name cannot be recreated.

And because \Neos\Neos\Domain\Service\WorkspaceService::getUniqueWorkspaceName only prevents naming conflict with existing workspaces that are projected attempting to create a workspace with the same title via Ui fails.

steps:

1. create workspace 'MyTest'
2. delete workspace
3. repeat

The error is as expected:

Workspace could not be created.
Expected version: -1 [no stream], actual version: 1

That means imo that getUniqueWorkspaceName needs to handle this case.

[bwaidelich]

very good catch

[kitsunet]

So this seems to hve no test then?

[mhsdesign]

jup the the core's DeleteWorkspace is fully untested - i have that somewhere in my todo list and stumble upon that every once and then. Also the cores CreateWorkspace is only tested implicit but not for such cases.