-
-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TASK: Documentation tweaks, add CR command reference #5460
Conversation
faa7f50
to
47887d2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is fantastic, thank you.
I only skimmed over the changes and could not find any obvious error, so +1 by reading.
We should merge this asap to prevent conflicts
Anyone up for a second approval, so I can merge this? |
Looks good, I just wonder why you've removed all ChangeLogs and ReleasNotes? |
Technically they were never supposed to be in there, but over the years we collected them due to upmerges. Original idea was to have only tthe ones for the current branch, so 8.1 branch contains all but only the 81x notes. |
Checklist
Tests have been created, run and adjusted as neededThe PR is created against the lowest maintained branchFEATURE|TASK|BUGFIX
Reviewer - Breaking Changes are marked with!!!
and have upgrade-instructions