TASK: adjust to overhauled node uri building #3802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhsdesign
force-pushed
the
task/adjustToOverhauledNodeUriBuilding
branch
from
fbf4ad5
to
5721481
Compare
6 tasks
This comment was marked as outdated.
This comment was marked as outdated.
mhsdesign
force-pushed
the
task/adjustToOverhauledNodeUriBuilding
branch
from
234b83e
to
b3055d4
Compare
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ui adjustments for neos/neos-development-collection#4892
Neos.Ui.NodeInfo.previewUriin eel instead ofurias thedocumentNodewill always be in a non live workspace either way and to better symbolise that we want to render a ABSOLUTE preview uri. Theurimethod could be removed.redirectToaction of theNeos.Neos.UiBackendControllerwill already work with the new node addressNeos.Ui.NodeInfo.createRedirectToNoderedirected in 8.3 to the node in the base workspace, this behaviour was restored as currently the user workspace is targeted which would be new accidental? behaviour changeLinkingService::createNodeUriwith new uri builderWhat I did
How I did it
How to verify it