FEATURE: Show drop targets when dragging text in the inline editor #3978
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The inline editor uses various elements for highlights which don’t work in the host frame. With this patch, we instead attach the collection to the guestframe body.
With this change, the user can see an indicator where selected elements in the inline editor would show up. The drag & drop feature worked before, but this makes the feature much more usable and intuitive. It even works between multiple editor instances. Resolves: #3977
Sebobo
force-pushed
the
bugfix/show-ck-editor-drop-targets
branch
from
b71d3cf to
1f375ed
Compare
Sebobo
changed the title
Sebobo
changed the title
Sebobo
changed the title
Sebobo
force-pushed
the
bugfix/show-ck-editor-drop-targets
branch
from
65204a4 to
61d048a
Compare
|
TODO: I think we should move the CK BodyCollection into our Neos backend container, so we have everything inside one element and could use layer styles and maybe a web component for these elements in the future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Show drag & drop indicators in inline editor. Resolves: #3977
How I did it
How to verify it
Neos.CKEditor.Drop.Indicator.Fix.mp4