FEATURE: Improve Node and Node interfaces rewrites #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kitsunet
reviewed
Nov 18, 2024
kitsunet
reviewed
Nov 18, 2024
|
Great work <3 |
mhsdesign
reviewed
Nov 20, 2024
tests/Sets/ContentRepository90/Fixture/Node/node-properties.php.inc
Outdated
Show resolved
Hide resolved
mhsdesign
reviewed
Nov 20, 2024
| return new NodeLegacyStub(); | ||
| } | ||
|
|
||
| public function getNode(): NodeLegacyStub { |
There was a problem hiding this comment.
so this thing contains the signature of the original node interface and some of the "forward compatible" changes of the traversable thing ... but this is just a helper during running the migration right? These methods like all the find* and get* would be the todo to be migrated right?
There was a problem hiding this comment.
Yes, correct. This is just to enable rector to determine the return type of methods, which not exists anymore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves the rewrites for node related code in general.
Fixes #57
Related: #75