Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FEATURE: Add warnings for removed signals #98

Merged
merged 1 commit into from
Nov 28, 2024
Merged

FEATURE: Add warnings for removed signals #98

merged 1 commit into from
Nov 28, 2024

Conversation

dlubitz
Copy link
Contributor

@dlubitz dlubitz commented Nov 22, 2024 •
edited
Loading

Fixes #48

Adds warnings for all removed signals:

Neos\ContentRepository\Domain\Model\Node

  • beforeNodeMove
  • afterNodeMove
  • beforeNodeCopy
  • afterNodeCopy
  • nodePathChanged
  • beforeNodeCreate
  • afterNodeCreate
  • nodeAdded
  • nodeUpdated
  • nodeRemoved
  • beforeNodePropertyChange
  • nodePropertyChanged

Neos\ContentRepository\Domain\Model\NodeData

  • nodePathChanged

Neos\ContentRepository\Domain\Model\Workspace

  • baseWorkspaceChanged
  • beforeNodePublishing
  • afterNodePublishing

Neos\ContentRepository\Domain\Repository\NodeDataRepository

  • repositoryObjectsPersisted

Neos\ContentRepository\Domain\Service\Context

  • beforeAdoptNode
  • afterAdoptNode

Neos\ContentRepository\Domain\Service\PublishingService

  • nodePublished
  • nodeDiscarded

@dlubitz dlubitz self-assigned this Nov 22, 2024
mhsdesign
mhsdesign approved these changes Nov 22, 2024
View reviewed changes
Copy link
Member

@mhsdesign mhsdesign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for all the work :D Hopefully that helps in combination with some guide explaining the new extension points ...

@ahaeslich ahaeslich self-requested a review November 27, 2024 08:48
@mhsdesign mhsdesign merged commit 549f6f8 into main Nov 28, 2024
2 checks passed
@mhsdesign mhsdesign deleted the feature/signal-slot-warning branch November 28, 2024 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhsdesign mhsdesign mhsdesign approved these changes

@ahaeslich ahaeslich Awaiting requested review from ahaeslich

Assignees

@dlubitz dlubitz

Labels
None yet
Projects
Neos 9.0 Release Board
Status: Done ✅
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add comments for removed signals
2 participants
@dlubitz @mhsdesign