Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEATURE: Implements Endpoint for Swift_Image class #20

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

SC-cmarquardt
Copy link

Adds Image.php Class as endpoint for the Swift_Image Class for embedding Images into messages.
See:
https://swiftmailer.symfony.com/docs/messages.html#embedding-inline-media-files

Adds Image.php Class as endpoint for the Swift_Image Class for embedding Images into messages.
See:
https://swiftmailer.symfony.com/docs/messages.html#embedding-inline-media-files
@SC-cmarquardt
Copy link
Author

Hi @daniellienert ,
can you please merge this PR?
Thanks

@daniellienert daniellienert changed the title Implements Endpoint for Swift_Image class FEATURE: Implements Endpoint for Swift_Image class Mar 23, 2021
Copy link
Member

@kdambekalns kdambekalns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand why you need this, yet. You could just use \Swift_Image as documented, no?

Classes/Image.php Outdated Show resolved Hide resolved
Classes/Image.php Outdated Show resolved Hide resolved
ichnoweb and others added 2 commits March 26, 2021 16:32
Removes empty line.

Co-authored-by: Karsten Dambekalns <[email protected]>
Co-authored-by: Karsten Dambekalns <[email protected]>
@ichnoweb
Copy link

ichnoweb commented Mar 26, 2021

@kdambekalns my idea is to have a single package interface. Not to fetch the Message class from this package, the Image class from Swiftmailer directly etc.

(I transfered ownership, that's why a "new user" replies)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants