fix(pyright): use activated virtual environment if possible #3554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: Pyright will use system python by default, even if we already have a virtual environment activated. Solution: Check current if `VIRTUAL_ENV` exists in environment variable, if so, set the default pythonPath with the binary inside.
laddertosky
changed the title
|
update the pr title to match commit lint |
|
You know you can reword a commit, right? You don't have to close the pull request and open a new one for every lint failure. |
|
Does this still work for remote commit? I thought git commit --amend only works for local commit. |
|
After --amend you need to force-push to your PR branch. Ask chatgpt or similar for more info. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
Pyright will use system python by default, even if we already have a virtual environment activated.
Solution:
Check current if
VIRTUAL_ENVexists in environment variable, if so, set the default pythonPath with the binary inside.