revert: "refactor!: make available_servers function private" #3589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinmk
reviewed
Jan 27, 2025
| @@ -223,7 +223,7 @@ function M.get_managed_clients() | |||
| return clients | |||
| end | |||
|
|
|||
| function M._available_servers() | |||
| function M.available_servers() | |||
There was a problem hiding this comment.
Suggested change
| function M.available_servers() | |
| --- @deprecated use `vim.lsp.confg` in Nvim 0.11+ instead. | |
| function M.available_servers() |
future: we should probably add lspconfig.util will be removed; use vim.lsp.confg in Nvim 0.11+ to all util.lua deprecation notices
There was a problem hiding this comment.
Wait, people using nvim 0.10 won't have a way to remove this warning. I guess it's an acceptable tradeoff?
There was a problem hiding this comment.
Our nvim-lspconfig deprecation plan didn't really consider concerns about non-breaking, soft warnings for Nvim 0.10, AFAIR. It doesn't strike me as too important, as long as their code doesn't break.
dundargoc
force-pushed
the
revert/available_servers
branch
from
1aebdd7 to
8f5d0d1
Compare
This reverts commit e118ce5. It turns out `util.available_servers` is used more than anticipated, so we revert the privatization for the time being. Closes neovim#3588.
dundargoc
force-pushed
the
revert/available_servers
branch
from
8f5d0d1 to
638d0bf
Compare
justinmk
approved these changes
Jan 27, 2025
This was referenced Jan 27, 2025
folke
pushed a commit
to folke/neoconf.nvim
that referenced
this pull request
Jan 28, 2025
## Description Reverts #105. [neovim/nvim-lspconfig - PR #3589](neovim/nvim-lspconfig#3589) reverts `_available_servers` back to `available_servers`. ## Related Issue(s) Fixes #107. ## Screenshots NA
mimikun
added a commit
to mimikun/dotfiles
that referenced
this pull request
Jan 28, 2025
breaking changes in nvim-lspconfig reverted by neovim/nvim-lspconfig#3589
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit e118ce5.
It turns out
util.available_serversis used more than anticipated, sowe revert the privatization for the time being.
Closes #3588.