Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(asyncio): close child_watcher before the main loop is closed #556

Closed
wants to merge 1 commit into from
Closed

fix(asyncio): close child_watcher before the main loop is closed #556

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions pynvim/msgpack_rpc/event_loop/asyncio.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -242,6 +242,11 @@ def _stop(self) -> None:

@override
def _close(self) -> None:

if self._child_watcher is not None:
self._child_watcher.close()
self._child_watcher = None

def _close_transport(transport):
transport.close()

Expand All @@ -264,10 +269,6 @@ async def wait_until_closed():

self._loop.close()

if self._child_watcher is not None:
self._child_watcher.close()
self._child_watcher = None

@override
def _threadsafe_call(self, fn: Callable[[], Any]) -> None:
self._loop.call_soon_threadsafe(fn)
Expand Down