Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Added initial django-cms 4.0.x compatibility #41

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from

Conversation

Aiky30
Copy link

@Aiky30 Aiky30 commented Apr 11, 2021

Description

Describe:

  • django-cms 4.0.x and backwards compatible changes

Checklist

  • I have read the contribution guide
  • Code lint checked via inv lint
  • changes file included (see docs)
  • Usage documentation added in case of new features
  • Tests added

@coveralls
Copy link

coveralls commented Apr 11, 2021

Coverage Status

Coverage decreased (-0.6%) to 99.375% when pulling ef3765c on Aiky30:feature/support-django-cms-4 into b866960 on nephila:develop.

@codecov
Copy link

codecov bot commented Apr 11, 2021

Codecov Report

Merging #41 (ef3765c) into develop (b866960) will decrease coverage by 1.24%.
The diff coverage is 77.77%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop      #41      +/-   ##
===========================================
- Coverage   100.00%   98.75%   -1.25%     
===========================================
  Files            4        6       +2     
  Lines          152      161       +9     
  Branches        23       24       +1     
===========================================
+ Hits           152      159       +7     
- Misses           0        1       +1     
- Partials         0        1       +1     
Flag Coverage Δ
unittests 98.75% <77.77%> (-1.25%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
djangocms_redirect/admin.py 93.10% <60.00%> (-6.90%) ⬇️
djangocms_redirect/compat.py 100.00% <100.00%> (ø)
djangocms_redirect/__init__.py 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b866960...ef3765c. Read the comment docs.

@Aiky30 Aiky30 changed the title WIP: Added initial django-cms 4.0.x compatibility Feature: Added initial django-cms 4.0.x compatibility Apr 11, 2021
@Aiky30 Aiky30 closed this Apr 11, 2021
@Aiky30 Aiky30 reopened this Apr 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants