Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix parsing error when entry from dict returns None #168

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions taiga/models/base.py
Original file line number Diff line number Diff line change
Expand Up @@ -104,14 +104,16 @@ def _new_resource(self, **attrs):
def parse(cls, requester, entries):
"""Parse a JSON array into a list of model instances."""
result_entries = SearchableList()
for entry in entries:
entry_list = entries if entries else []
for entry in entry_list:
result_entries.append(cls.instance.parse(requester, entry))
return result_entries

def parse_list(self, entries):
"""Parse a JSON array into a list of model instances."""
result_entries = SearchableList()
for entry in entries:
entry_list = entries if entries else []
for entry in entry_list:
result_entries.append(self.instance.parse(self.requester, entry))
return result_entries

Expand Down
Loading