Fixing some of the linting erorrs #176
Conversation
Signed-off-by: Gergely Csatari <[email protected]>
Signed-off-by: Gergely Csatari <[email protected]>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
✅ Deploy Preview for nephio ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Signed-off-by: Gergely Csatari <[email protected]>
|
@CsatariGergely vale seems to complain on some capitalization (and couple on choice of wording) errors. PTAL. |
Yep, it is a massive list :) I will also configure it not to fail the check, but only post warnings. I would like to use these as more like recommendations for now. |
Signed-off-by: Gergely Csatari <[email protected]>
|
New changes are detected. LGTM label has been removed. |
|
Now it is strange, that the Vale check is not triggered for every update. |
Signed-off-by: Gergely Csatari <[email protected]>
| @@ -129,11 +129,11 @@ The following limitations need to be borne in mind: | |||
| does not match src line`. | |||
| If such a message appears, then retry in a little while, as this error may resolve itself. Restarting | |||
| Porch may also help. | |||
| * During specialization, we may have duplicate parameterRef extensions, leading to failed deployments | |||
| * During specialization, we may have duplicate parameterRef extensions, leading to unsuccesfull deployments | |||
There was a problem hiding this comment.
| * During specialization, we may have duplicate parameterRef extensions, leading to unsuccesfull deployments | |
| * During specialization, we may have duplicate parameterRef extensions, leading to unsuccesful deployments |
There was a problem hiding this comment.
I don't know why the word "unsuccessful" is spelt that way in English (it makes no sense) :-D
There was a problem hiding this comment.
Actually I don't know why our doc checking/lint tool would find "failed" deployments offensively, it is a much better wording to capture the reality than an "unsuccessful" deployment.
This is still in the works, do not approve it. I just need the Vale job to run.