Skip to content

Added example manifest of function pod service in function runner page of porch documentation #249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Added example manifest of function pod service in function runner page of porch documentation #249

wants to merge 1 commit into from

Conversation

gkumar78
Copy link
Contributor

No description provided.

@nephio-prow nephio-prow bot requested a review from johnbelamaric July 17, 2025 10:30
@netlify Netlify
Copy link

netlify bot commented Jul 17, 2025 •
edited
Loading

✅ Deploy Preview for nephio ready!

Name Link
🔨 Latest commit be21dbc
🔍 Latest deploy log https://app.netlify.com/projects/nephio/deploys/6878d0aa20ee240008ea3145
😎 Deploy Preview https://deploy-preview-249--nephio.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@nephio-prow nephio-prow bot requested a review from liamfallon July 17, 2025 10:30
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@gkumar78 gkumar78 mentioned this pull request Jul 17, 2025
Open
@gkumar78 gkumar78 requested a review from kushnaidu July 20, 2025 15:55
@kushnaidu
Copy link
Contributor

/approve

@nephio-prow Nephio PROW
Copy link
Contributor

nephio-prow bot commented Jul 21, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kushnaidu
Once this PR has been reviewed and has the lgtm label, please assign henderiw for approval by writing /assign @henderiw in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

efiacor
efiacor reviewed Jul 22, 2025
View reviewed changes
content/en/docs/porch/function-runner-pod-templates.md
Additionally, porch-fn-runner pod needs to be have access to read this pod template configmap. Assuming porch-fn-runner pod is running in porch-system namespace, following Role and Rolebindings needs to be added to porch deployment manifests.

```yaml
kind: Role
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This RBAC should be added to the catalog and deployments/porch pkgs

@gkumar78 gkumar78 mentioned this pull request Jul 23, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@efiacor efiacor efiacor left review comments

@johnbelamaric johnbelamaric Awaiting requested review from johnbelamaric

@liamfallon liamfallon Awaiting requested review from liamfallon

@kushnaidu kushnaidu Awaiting requested review from kushnaidu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gkumar78 @kushnaidu @efiacor