Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gsplat version number to build directory. #320

Conversation

keunhong
Copy link
Contributor

@keunhong keunhong commented Aug 7, 2024

This ensures that the extension is compiled when the library is upgraded.

Resolves #318.

@keunhong keunhong force-pushed the build-directory-name-version branch from e2dbfbf to 022e4df Compare August 7, 2024 08:32
@keunhong keunhong marked this pull request as ready for review August 7, 2024 08:33
This ensures that the extension is compiled when the library is
upgraded.
@keunhong keunhong force-pushed the build-directory-name-version branch from 022e4df to c8c4ae1 Compare August 7, 2024 08:57
@liruilong940607
Copy link
Collaborator

liruilong940607 commented Aug 7, 2024

Did you encounter this problem in an actual run?

This feels a bit strange because JIT build does on-the-fly comparison on the hashing of the files and if any file changes it will trigger rebuild during JIT load():

return load(

Code reference in torch:

https://github.com/pytorch/pytorch/blob/40ce0a53bb4dd4e5e8aa886fb29334f981595023/torch/utils/cpp_extension.py#L1680

I would be curious to look into it if you have this problem in an actual run.

@liruilong940607
Copy link
Collaborator

I did a test on this. It seems like at least in the latest release it will trigger the rebuilt if you upgrade it with pip, which is as expected. So I'm closing this for now. Feel free to reopen it if this is not the case.

# install v1.1.0
pip install gsplat==1.1.0
python -c "from gsplat.cuda._backend import _C; print(_C)"

# replace v1.1.0 with v1.3.0
pip install gsplat==1.3.0
python -c "from gsplat.cuda._backend import _C; print(_C)"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JIT-compiled extension and library version.
2 participants