Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix parsing of non ascii image names in colmap's images.bin #3256

Merged
merged 4 commits into from
Jun 28, 2024
Merged

Fix parsing of non ascii image names in colmap's images.bin #3256

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a086b14
Fix parsing of non ascii image names in colmap's images.bin
TamirCohen Jun 25, 2024
69f9d40
Merge branch 'main' into fix_parsing_of_non_ascii_names
kerrj Jun 27, 2024
201e641
Triggering Build after lint fix
TamirCohen Jun 28, 2024
8d1246c
Merge remote-tracking branch 'upstream/main' into fix_parsing_of_non_…
TamirCohen Jun 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions nerfstudio/data/utils/colmap_parsing_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,11 +235,12 @@ def read_images_binary(path_to_model_file):
qvec = np.array(binary_image_properties[1:5])
tvec = np.array(binary_image_properties[5:8])
camera_id = binary_image_properties[8]
image_name = ""
image_name = b""
current_char = read_next_bytes(fid, 1, "c")[0]
while current_char != b"\x00": # look for the ASCII 0 entry
image_name += current_char.decode("utf-8")
image_name += current_char
current_char = read_next_bytes(fid, 1, "c")[0]
image_name = image_name.decode("utf-8")
num_points2D = read_next_bytes(fid, num_bytes=8, format_char_sequence="Q")[0]
x_y_id_s = read_next_bytes(fid, num_bytes=24 * num_points2D, format_char_sequence="ddq" * num_points2D)
xys = np.column_stack([tuple(map(float, x_y_id_s[0::3])), tuple(map(float, x_y_id_s[1::3]))])
Expand Down
Loading