Adding double side for mesh (#12)

* trying to add mesh double side * Sync message defs + built client --------- Co-authored-by: Brent Yi <[email protected]>
nerfstudio-project · May 8, 2023 · eed8b09 · eed8b09
1 parent ca83635
commit eed8b09
Show file tree

Hide file tree

Showing 9 changed files with 13 additions and 8 deletions.
diff --git a/viser/_message_api.py b/viser/_message_api.py
@@ -507,6 +507,7 @@ def add_mesh(
         | Tuple[float, float, float]
         | onp.ndarray = (90, 200, 255),
         wireframe: bool = False,
+        side: Literal["front", "back", "double"] = "front",
         wxyz: Tuple[float, float, float, float] | onp.ndarray = (1.0, 0.0, 0.0, 0.0),
         position: Tuple[float, float, float] | onp.ndarray = (0.0, 0.0, 0.0),
         visible: bool = True,
@@ -520,6 +521,7 @@ def add_mesh(
                 # (255, 255, 255) => 0xffffff, etc
                 color=_encode_rgb(color),
                 wireframe=wireframe,
+                side=side
             )
         )
         return SceneNodeHandle._make(self, name, wxyz, position, visible)

diff --git a/viser/_messages.py b/viser/_messages.py
@@ -116,6 +116,7 @@ class MeshMessage(Message):
     faces: onpt.NDArray[onp.uint32]
     color: int
     wireframe: bool
+    side: Literal["front", "back", "double"] = "front"
 
     def __post_init__(self):
         # Check shapes.

diff --git a/viser/client/build/asset-manifest.json b/viser/client/build/asset-manifest.json
@@ -1,13 +1,13 @@
 {
   "files": {
     "main.css": "/static/css/main.82973013.css",
-    "main.js": "/static/js/main.6587bad7.js",
+    "main.js": "/static/js/main.3b78e278.js",
     "index.html": "/index.html",
     "main.82973013.css.map": "/static/css/main.82973013.css.map",
-    "main.6587bad7.js.map": "/static/js/main.6587bad7.js.map"
+    "main.3b78e278.js.map": "/static/js/main.3b78e278.js.map"
   },
   "entrypoints": [
     "static/css/main.82973013.css",
-    "static/js/main.6587bad7.js"
+    "static/js/main.3b78e278.js"
   ]
 }
diff --git a/viser/client/build/index.html b/viser/client/build/index.html
@@ -1 +1 @@
-<!doctype html><html lang="en"><head><meta charset="utf-8"/><link rel="icon" href="/favicon.svg"/><meta name="viewport" content="width=device-width,initial-scale=1"/><meta name="theme-color" content="#000000"/><meta name="description" content="Web site created using create-react-app"/><link rel="apple-touch-icon" href="/logo192.png"/><link rel="manifest" href="/manifest.json"/><title>Viser</title><script defer="defer" src="/static/js/main.6587bad7.js"></script><link href="/static/css/main.82973013.css" rel="stylesheet"></head><body><noscript>You need to enable JavaScript to run this app.</noscript><div id="root"></div></body></html>
+<!doctype html><html lang="en"><head><meta charset="utf-8"/><link rel="icon" href="/favicon.svg"/><meta name="viewport" content="width=device-width,initial-scale=1"/><meta name="theme-color" content="#000000"/><meta name="description" content="Web site created using create-react-app"/><link rel="apple-touch-icon" href="/logo192.png"/><link rel="manifest" href="/manifest.json"/><title>Viser</title><script defer="defer" src="/static/js/main.3b78e278.js"></script><link href="/static/css/main.82973013.css" rel="stylesheet"></head><body><noscript>You need to enable JavaScript to run this app.</noscript><div id="root"></div></body></html>
diff --git a/...r/client/build/static/js/main.6587bad7.js → ...r/client/build/static/js/main.3b78e278.js b/...r/client/build/static/js/main.6587bad7.js → ...r/client/build/static/js/main.3b78e278.js
diff --git a/...ld/static/js/main.6587bad7.js.LICENSE.txt → ...ld/static/js/main.3b78e278.js.LICENSE.txt b/...ld/static/js/main.6587bad7.js.LICENSE.txt → ...ld/static/js/main.3b78e278.js.LICENSE.txt
diff --git a/...ient/build/static/js/main.6587bad7.js.map → ...ient/build/static/js/main.3b78e278.js.map b/...ient/build/static/js/main.6587bad7.js.map → ...ient/build/static/js/main.3b78e278.js.map
diff --git a/viser/client/src/WebsocketInterface.tsx b/viser/client/src/WebsocketInterface.tsx
@@ -164,6 +164,7 @@ function useMessageHandler() {
         const material = new THREE.MeshStandardMaterial({
           color: message.color,
           wireframe: message.wireframe,
+          side: {"front": THREE.FrontSide, "back": THREE.BackSide, "double": THREE.DoubleSide}[message.side],
         });
         geometry.setAttribute(
           "position",

diff --git a/viser/client/src/WebsocketMessages.tsx b/viser/client/src/WebsocketMessages.tsx
@@ -48,6 +48,7 @@ interface MeshMessage {
   faces: ArrayBuffer;
   color: number;
   wireframe: boolean;
+  side: "front" | "back" | "double";
 }
 interface TransformControlsMessage {
   type: "TransformControlsMessage";
Original file line number	Diff line number	Diff line change
		@@ -1 +1 @@
		<!doctype html><html lang="en"><head><meta charset="utf-8"/><link rel="icon" href="/favicon.svg"/><meta name="viewport" content="width=device-width,initial-scale=1"/><meta name="theme-color" content="#000000"/><meta name="description" content="Web site created using create-react-app"/><link rel="apple-touch-icon" href="/logo192.png"/><link rel="manifest" href="/manifest.json"/><title>Viser</title><script defer="defer" src="/static/js/main.6587bad7.js"></script><link href="/static/css/main.82973013.css" rel="stylesheet"></head><body><noscript>You need to enable JavaScript to run this app.</noscript><div id="root"></div></body></html>
		<!doctype html><html lang="en"><head><meta charset="utf-8"/><link rel="icon" href="/favicon.svg"/><meta name="viewport" content="width=device-width,initial-scale=1"/><meta name="theme-color" content="#000000"/><meta name="description" content="Web site created using create-react-app"/><link rel="apple-touch-icon" href="/logo192.png"/><link rel="manifest" href="/manifest.json"/><title>Viser</title><script defer="defer" src="/static/js/main.3b78e278.js"></script><link href="/static/css/main.82973013.css" rel="stylesheet"></head><body><noscript>You need to enable JavaScript to run this app.</noscript><div id="root"></div></body></html>