Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Summary: An exception is thrown when the native animation code attempts to play an animation on a view that hasn't been created yet. This can happen because views are created in batches. If this particular view didn't make it into a batch yet, the view won't exist and an exception will be thrown when attempting to start an animation on it. This change eats the exception rather than crashing. The impact is that the app may drop one or more frames of the animation. **Notes** I'm not familiar enough with the Android native animation code to know whether or not this is a good fix. My team is using this change in our app because dropping animation frames is better than crashing the app. [This is the code](https://github.com/facebook/react-native/blob/c612c615449b8645976429ad1c0661a4f6e56115/ReactAndroid/src/main/java/com/facebook/react/uimanager/UIViewOperationQueue.java#L874-L892) that is creating the views in batches. Hopefully my PR at least provides some insight into the cause of the bug. This may fix facebook#9887 Closes facebook#10907 Differential Revision: D4340129 Pulled By: lacker fbshipit-source-id: 69160d9e71281a96a7445d764b4715a3e54c0357
- Loading branch information