Making CompiledSourceError a C enum, to keep JSBase.h as a C header

Reviewed By: javache

Differential Revision: D4299281

fbshipit-source-id: 14cdc6d4502a70300919dc6a98a5f274076134c7

ReactCommon/cxxreact/JSCExecutor.cpp

@@ -382,23 +382,25 @@ void JSCExecutor::loadApplicationScript(
   JSCompiledSourceError jsError;
   auto bcSourceCode = JSCreateCompiledSourceCode(fd, jsSourceURL, &jsError);
 
-  if (jsError == JSCompiledSourceErrorOnRead ||
-      jsError == JSCompiledSourceErrorNotCompiled) {
+  switch (jsError) {
+  case JSCompiledSourceErrorOnRead:
+  case JSCompiledSourceErrorNotCompiled:
     // Not bytecode, fall through.
     return JSExecutor::loadApplicationScript(fd, sourceURL);
-  } else if (jsError == JSCompiledSourceErrorVersionMismatch) {
+
+  case JSCompiledSourceErrorVersionMismatch:
     throw std::runtime_error("Compiled Source Version Mismatch");
-  }
 
-  folly::throwOnFail<std::runtime_error>(
-    jsError == JSCompiledSourceErrorNone,
-    "Unhandled Compiled Source Error"
-  );
+  case JSCompiledSourceErrorNone:
+    folly::throwOnFail<std::runtime_error>(
+      bcSourceCode != nullptr,
+      "Unexpected error opening compiled bundle"
+    );
+    break;
 
-  folly::throwOnFail<std::runtime_error>(
-    bcSourceCode != nullptr,
-    "Unexpected error opening compiled bundle"
-  );
+  default:
+    throw std::runtime_error("Unhandled Compiled Source Error");
+  }
 
   ReactMarker::logMarker("RUN_JS_BUNDLE_START");