Skip to content

Commit

Permalink
Fix instructions in 'react-native init'
Browse files Browse the repository at this point in the history
Summary: This was buggy and didn't print the folder we need to cd into.

Reviewed By: mkonicek

Differential Revision:
D4313396
Ninja: OSS only

fbshipit-source-id: 0e15baf818065b63e939def60a1366e2251aac7d
  • Loading branch information
Martin Konicek authored and Facebook Github Bot committed Dec 12, 2016
1 parent 46f3ff6 commit 8c7f360
Showing 1 changed file with 2 additions and 5 deletions.
7 changes: 2 additions & 5 deletions local-cli/generator/printRunInstructions.js
Original file line number Diff line number Diff line change
Expand Up @@ -13,22 +13,19 @@ var path = require('path');

function printRunInstructions(projectDir, projectName) {
const absoluteProjectDir = path.resolve(projectDir);
const relativeProjectDir = path.relative(process.cwd(), absoluteProjectDir);
// If we're in the project directory already, no need to 'cd' into it
const needToCd = !!relativeProjectDir;
// iOS
const xcodeProjectPath = path.resolve(projectDir, 'ios', projectName) + '.xcodeproj';
const relativeXcodeProjectPath = path.relative(process.cwd(), xcodeProjectPath);
console.log(chalk.white.bold('To run your app on iOS:'));
if (needToCd) { console.log(' cd ' + relativeProjectDir); }
console.log(' cd ' + absoluteProjectDir);
console.log(' react-native run-ios');
console.log(' - or -');
console.log(' Open ' + relativeXcodeProjectPath + ' in Xcode');
console.log(' Hit the Run button');
// Android
console.log(chalk.white.bold('To run your app on Android:'));
console.log(' cd ' + absoluteProjectDir);
console.log(' Have an Android emulator running (quickest way to get started), or a device connected');
if (needToCd) { console.log(' cd ' + relativeProjectDir); }
console.log(' react-native run-android');
}

Expand Down

0 comments on commit 8c7f360

Please sign in to comment.