Skip to content

Commit

Permalink
REACT_NATIVE_DIR needs quoting to retain spaces
Browse files Browse the repository at this point in the history
Summary:
${REACT_NATIVE_DIR} needs to be quoted as "${REACT_NATIVE_DIR}" otherwise projects paths with spaces in, will fail to build.

e.g. a project in `/home/me/some folder` will fail to build with:

```
../node_modules/react-native/packager/react-native-xcode.sh: line 37: cd: /home/me/some: No such file or directory
```
Closes facebook#11487

Differential Revision: D4336281

Pulled By: lacker

fbshipit-source-id: c5d19fbd21978714c7af44c305ba854477118e1d
  • Loading branch information
jaygooby authored and facebook-github-bot committed Dec 16, 2016
1 parent eba356f commit c93643c
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion packager/react-native-xcode.sh
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ esac
REACT_NATIVE_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")/.." && pwd)"

# Xcode project file for React Native apps is located in ios/ subfolder
cd ${REACT_NATIVE_DIR}/../..
cd "${REACT_NATIVE_DIR}"/../..

# Define NVM_DIR and source the nvm.sh setup script
[ -z "$NVM_DIR" ] && export NVM_DIR="$HOME/.nvm"
Expand Down

0 comments on commit c93643c

Please sign in to comment.