You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The Engine currently contains functionality for cycling to the previous_animation and next_animation (shown below). However, in the 2020-06-23 meeting we realized these are responsibilities of the application rather than the rendering engine. Therefore, we should move this code out of Engine, leaving the engine with the play_animation function for the application to tell the engine which animation should currently be playing.
The text was updated successfully, but these errors were encountered:
amclain
added
feature
A new feature or enhancement to an existing feature
refactor
Refactoring code or tech debt repayment
and removed
feature
A new feature or enhancement to an existing feature
labels
Jun 25, 2020
This was sorta done, should we close this ticket? Or should we change this ticket to reflect that we're still not happy with the functionality being inside the Keys server?
The
Engine
currently contains functionality for cycling to theprevious_animation
andnext_animation
(shown below). However, in the 2020-06-23 meeting we realized these are responsibilities of the application rather than the rendering engine. Therefore, we should move this code out ofEngine
, leaving the engine with theplay_animation
function for the application to tell the engine which animation should currently be playing.https://github.com/ElixirSeattle/xebow/blob/e5589fdec01278b23f043fea198c164ce97eed01/lib/xebow/engine.ex#L31-L45
The text was updated successfully, but these errors were encountered: