Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: Cycling to a previous or next animation is the application's responsibility #36

Closed
amclain opened this issue Jun 25, 2020 · 2 comments
Labels
refactor Refactoring code or tech debt repayment

Comments

@amclain
Copy link
Member

amclain commented Jun 25, 2020

The Engine currently contains functionality for cycling to the previous_animation and next_animation (shown below). However, in the 2020-06-23 meeting we realized these are responsibilities of the application rather than the rendering engine. Therefore, we should move this code out of Engine, leaving the engine with the play_animation function for the application to tell the engine which animation should currently be playing.

https://github.com/ElixirSeattle/xebow/blob/e5589fdec01278b23f043fea198c164ce97eed01/lib/xebow/engine.ex#L31-L45

@amclain amclain added feature A new feature or enhancement to an existing feature refactor Refactoring code or tech debt repayment and removed feature A new feature or enhancement to an existing feature labels Jun 25, 2020
@doughsay
Copy link
Member

doughsay commented Jul 6, 2020

This was sorta done, should we close this ticket? Or should we change this ticket to reflect that we're still not happy with the functionality being inside the Keys server?

@amclain
Copy link
Member Author

amclain commented Jul 6, 2020

I think we can close it. The keys server is a different topic.

Resolved in #50.

@amclain amclain closed this as completed Jul 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Refactoring code or tech debt repayment
Projects
None yet
Development

No branches or pull requests

2 participants