Add tests for engine #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amclain
force-pushed
the
tech-debt/add-engine-tests
branch
from
0eb786a to
7993996
Compare
Also supply engine with an initial animation.
amclain
force-pushed
the
tech-debt/add-engine-tests
branch
from
7993996 to
00a9e1c
Compare
doughsay
approved these changes
Jul 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds some unit tests for
Engine. I intentionally omitted testingnext_animationandprevious_animationsince those functions are slated to be removed fromEnginein #36. Hopefully these tests aid in that refactor by solidifying some of the expected behavior ofEngine.I should note that I also moved the responsibility of choosing the initial animation. Instead having the engine decide this, it now accepts an
initial_animation. Not only did this make testing easier, but it is probably a better design when building an app with Xebow as well. This will let a developer choose the initial animation easier.