-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add NCM to networking configuration for OSX Catalina (10.15) compatibility #94
Conversation
We can remove it again, if it causes problems.
Just until it gets merged in upstream Fork available at https://github.com/vanvoljg/nerves_system_keybow
187e435
to
b2ea4f1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Exposing 3 ethernet endpoints to the host simultaneously feels excessive and brittle to me, but I'm ok moving forward with this as the next step considering it fixes incompatibility with a platform. Something to think about for the next iteration of the USB ethernet endpoints: What if rather than bonding the adapters in the device, check which adapters can communicate with the host and disable all of the ones that are not the preferred adapter. If we can listen for USB hotplug events we could also know when to enable all of the adapters when the device is plugged in, although we may be able to detect this in other ways as well.
I agree, it already annoys me that I have two interfaces that show up on linux, and one doesn't work. It always tries to re-connect, causing notification spam. And what happens if two work? If both connect successfully what happens?
This would be amazing and nullify the concern above. But I'm not sure how to pull it off... |
cd82a6f
to
95d7130
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
run mix deps.get
and check in the mix.lock changes
@vanvoljg there are still some changes left in here that reverence usb2, but looks like you opted to remove ecm in the end? |
I knew there was something I'd forgotten. Cheers.
Comment documentation? Fixed! Thanks for the reminder. Any other references to usb2 are for the HID device. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
This addresses the issue of getting the Xebow to connect to a Mac running Catalina, OSX 10.15. The fix adds an NCM function to the ConfigFS-based USB gadget that we set up to make everything work over one USB port.
This is dependent on PR #3 of
nerves_system_keybow
getting merged in, along with generation of a new release tag and Nerves artifact.I went and left ECM in to increase compatibility, in case some hosts are unable to use the other modes.
@doughsay could you give it a whirl on your Mac again to make sure that my adding ECM back in didn't mess anything up?
It can always get taken out again, if it causes issues.
nerves_system_keybow
dependency versionFixes #90
Fixes #91